bij1
/
terraform-provider-greenhost
19
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Mark the kubernetes_cluster resource's kube_config field as sensitive 

This data includes sensitive information about the cluster, such as its private
key. This prevents that data from ending up in, for example, logs on a CI system
that does a `terraform plan` as part of its build.

With this applied, a `terraform plan` or `terraform apply` instead shows:

```
...
        ipv4_address   = "1.2.3.4"
        kube_config    = (sensitive value)
        name           = "roboticcheese"
...
```

Also updates the acceptance tests, as 1.14.4-do.0 is no longer available.
This commit is contained in:
Jonathan Hartman 2019-08-31 11:32:54 -07:00
parent 9476634de1
commit f7b97cb7e8
No known key found for this signature in database
GPG Key ID: 5D9600982D910C6B
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
digitalocean/resource_digitalocean_kubernetes_cluster.go
View File

@ -100,8 +100,9 @@ func resourceDigitalOceanKubernetesCluster() *schema.Resource {
func kubernetesConfigSchema() *schema.Schema {
return &schema.Schema{
Type: schema.TypeList,
Computed: true,
Type: schema.TypeList,
Computed: true,
Sensitive: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"raw_config": {

12
digitalocean/resource_digitalocean_kubernetes_cluster_test.go
View File

@ -27,7 +27,7 @@ func TestAccDigitalOceanKubernetesCluster_Basic(t *testing.T) {
testAccCheckDigitalOceanKubernetesClusterExists("digitalocean_kubernetes_cluster.foobar", &k8s),
resource.TestCheckResourceAttr("digitalocean_kubernetes_cluster.foobar", "name", rName),
resource.TestCheckResourceAttr("digitalocean_kubernetes_cluster.foobar", "region", "lon1"),
resource.TestCheckResourceAttr("digitalocean_kubernetes_cluster.foobar", "version", "1.14.4-do.0"),
resource.TestCheckResourceAttr("digitalocean_kubernetes_cluster.foobar", "version", "1.15.3-do.1"),
resource.TestCheckResourceAttrSet("digitalocean_kubernetes_cluster.foobar", "ipv4_address"),
resource.TestCheckResourceAttrSet("digitalocean_kubernetes_cluster.foobar", "cluster_subnet"),
resource.TestCheckResourceAttrSet("digitalocean_kubernetes_cluster.foobar", "service_subnet"),
@ -183,7 +183,7 @@ func testAccDigitalOceanKubernetesConfigBasic(rName string) string {
resource "digitalocean_kubernetes_cluster" "foobar" {
name = "%s"
region = "lon1"
version = "1.14.4-do.0"
version = "1.15.3-do.1"
tags = ["foo","bar", "one"]
node_pool {
@ -201,7 +201,7 @@ func testAccDigitalOceanKubernetesConfigBasic2(rName string) string {
resource "digitalocean_kubernetes_cluster" "foobar" {
name = "%s"
region = "lon1"
version = "1.14.4-do.0"
version = "1.15.3-do.1"
tags = ["foo","bar"]
node_pool {
@ -219,7 +219,7 @@ func testAccDigitalOceanKubernetesConfigBasic3(rName string) string {
resource "digitalocean_kubernetes_cluster" "foobar" {
name = "%s"
region = "lon1"
version = "1.14.4-do.0"
version = "1.15.3-do.1"
tags = ["foo","bar"]
node_pool {
@ -237,7 +237,7 @@ func testAccDigitalOceanKubernetesConfigBasic4(rName string) string {
resource "digitalocean_kubernetes_cluster" "foobar" {
name = "%s"
region = "lon1"
version = "1.14.4-do.0"
version = "1.15.3-do.1"
tags = ["one","two"]
node_pool {
@ -255,7 +255,7 @@ func testAccDigitalOceanKubernetesConfig_KubernetesProviderInteroperability(rNam
resource "digitalocean_kubernetes_cluster" "foobar" {
name = "%s"
region = "lon1"
version = "1.14.4-do.0"
version = "1.15.3-do.1"
node_pool {
name = "default"